search

mattetti / googlecharts

Ruby Google Chart API
http://mattetti.github.com/googlecharts/
MIT License
699 stars 108 forks source link

Charts with axis_labels do not display in gmail #28

Open peterkovacs opened 14 years ago

peterkovacs commented 14 years ago

Displaying a chart in Gmail does not work with the current jstize function. It seems that Gmail chokes on unescaped | (pipe) characters for a labelled line chart, prefering the URL-encoded version. If jstize is replaced with URI.escape, then the chart renders correctly in Gmail.

The discussion for 9b5cfb93aa51aae06611 makes it seem like this is intentional. However, URI.escape does not seem to break the display of any of the other example charts listed on http://googlecharts.rubyforge.org/

hisham commented 13 years ago

Was this checked in? I see issue #27 (which is the same as this issue) in the code's comments:

# See http://github.com/mattetti/googlecharts/issues#issue/27
#URI.escape( string ).gsub("%7C", "|")
peterkovacs commented 13 years ago

As far as I know it was never merged.

Edited: Ah, i screwed up when I made the issue. so I created this one to include the pull request.