search

mattetti / googlecharts

Ruby Google Chart API
http://mattetti.github.com/googlecharts/
MIT License
699 stars 108 forks source link

Fix errors with rake tasks and restoring labels #34

Closed aderyabin closed 13 years ago

aderyabin commented 13 years ago

Hello. I found that googlecharts don't support official docs with 'labels' option. I fix this bug and also remove rake tasks because it cause errors.

Please add my commits to your gem. I think it will be useful for all developers.

Thanks, Andrey Deryabin Evil Martians

mattetti commented 13 years ago

I applied your first 2 commits but the tasks are working great for me and I need them to push the gems. You need to have jeweler installed, it's not awesome, but i'm too lazy to change that :p

Thanks for the patch and the tests, I also pushed version 1.6.2 out there. Let me know if you are interested in getting commit access to the repo.

aderyabin commented 13 years ago

As for commit access, it will be great. I promise clean and working code

mattetti commented 13 years ago

For some reason I never saw your reply, I just added you as a contributor :)