search

mattevans / pwned-passwords

🔐Go client library for checking values against compromised HIBP Pwned Passwords
MIT License
86 stars 7 forks source link

Provide the number of times a particular password was pwned #4

Open SeanFarrow opened 5 years ago

SeanFarrow commented 5 years ago

It would be nice to have the number of times a password was pwned returned rather than just a true/false value as to whether it was actually pwned.

Then we could add an IsPwned method to the PwnedStore struct to allow a user to use the old behaviour if this was desired.

I'm happy to make this change if it's something you would accept?

mattevans commented 5 years ago

@SeanFarrow Sounds good. Thanks. Lodge a PR and lets get it merged 👍

SeanFarrow commented 5 years ago

@mattevans, OK, I'll fork and work on this tomorrow. What are you doing regarding testing in terms of new methods?

mattevans commented 5 years ago

Perhaps the pwnd count could be returned as part of a new method (rather than Compromised()). Tests are using the onsi/gomega pkg. You can easily add tests to pwned_test.go (here - take a look how some of the others are implemented.

SeanFarrow commented 5 years ago

I’m thinking a method such as CompromisedWithPwnedCount, how does this sound? I’ll have a look at the tests later today From: Matt Evans notifications@github.com Sent: 08 March 2019 05:59 To: mattevans/pwned-passwords pwned-passwords@noreply.github.com Cc: Sean Farrow sean.farrow@seanfarrow.co.uk; Assign assign@noreply.github.com Subject: Re: [mattevans/pwned-passwords] Provide the number of times a particular password was pwned (#4)

Perhaps the pwnd count could be returned as part of a new method (rather than Compromised()). Tests are using the onsi/gomega<github.com/onsi/gomega> pkg. You can easily add tests to pwned_test.go (herehttps://github.com/mattevans/pwned-passwords/blob/master/pwned_test.go - take a look how some of the others are implemented.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/mattevans/pwned-passwords/issues/4#issuecomment-470815526, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABY1fqPkruqyIG8ner4Yt6xO1nzES1vEks5vUfwfgaJpZM4bf28U.