search

mattfbacon / typst-bot

A discord bot to render Typst code
GNU Affero General Public License v3.0
56 stars 11 forks source link

Docker #7

Closed JL710 closed 1 year ago

JL710 commented 1 year ago

I added the files that can be used to run the bot as docker container. This can make the set up much easier.

mattfbacon commented 1 year ago

This would definitely be a good addition. I noticed some grammar, spelling, and formatting issues that are inconsequential and that I can fix myself. However, with the Dockerfile I was wondering if we could implement the two-stage design where the first stage builds the binaries and the second stage runs them. https://dev.to/deciduously/use-multi-stage-docker-builds-for-statically-linked-rust-binaries-3jgd

JL710 commented 1 year ago

This would definitely be a good addition. I noticed some grammar, spelling, and formatting issues that are inconsequential and that I can fix myself. However, with the Dockerfile I was wondering if we could implement the two-stage design where the first stage builds the binaries and the second stage runs them. https://dev.to/deciduously/use-multi-stage-docker-builds-for-statically-linked-rust-binaries-3jgd

Sorry for any issues with grammar, spelling etc.. The two stage design looks cool. That's definitely something we should do.

mattfbacon commented 1 year ago

Okay, looks good, I will add the minor fixes and merge. Thanks.