mattfidler / tabbar-ruler.el

Tabbar Ruler Mode
54 stars 10 forks source link

fancy-tab-separator for current tab #27

Closed rhoit closed 8 years ago

rhoit commented 8 years ago

just some hackish changes to improve the looks.

(tab-content right-tab-ending left-tab-ending) → (left-tab-ending tab-content right-tab-ending)

added new variable

tabbar-ruler-fancy-current-tab-separator

screenshot with config:

(setq tabbar-ruler-fancy-current-tab-separator 'wave)
(setq tabbar-ruler-fancy-tab-separator 'alternate)

screenshot62

screenshot61

mattfidler commented 8 years ago

This looks odd when using text

image

mattfidler commented 8 years ago

Also the direction is wrong

image

mattfidler commented 8 years ago

Its been added back again...

rhoit commented 8 years ago

yup it definitely, needs more improvements, I was more focused on changing looks. Strange although why direction went wrong.

screenshot71

TODO:

mattfidler commented 8 years ago

Before: screenshot-tabbar-ruler-20160108 623 After: screenshot-tabbar-ruler-20160114 642

Other people are having problems as well.

rhoit commented 8 years ago

above config seems ok to me, if you keep

(setq tabbar-ruler-fancy-current-tab-separator 'nil)
(setq tabbar-ruler-fancy-tab-separator 'butt)

screenshot67

P.S. Ignore the color I got the different color config.

mattfidler commented 8 years ago

I think it should have separators between the tabs and not have the |.

I think I fixed the text only, and may have also fixed the above. Please check to let me know.

rhoit commented 8 years ago

i have been trying lots of different combination, but separator between tabs doesn't look good!

separator between tabs

last tab selected

screenshot68

middle tab selected

screenshot69

without separator between tabs

first tab selected

screenshot75

second tab selected

screenshot74

third tab selected

screenshot73

thought

how about adding only single separator like the firefox does

screenshot76

rhoit commented 8 years ago

my current config looks like this,

screenshot77

with setting, most of the color are hard coded

(custom-set-faces
 '(tabbar-button ((t (:background "#c5c5c5"))))
 '(tabbar-default ((t (:background "#c5c5c5"))))

(setq tabbar-separator-value 0)
(setq tabbar-ruler-fancy-current-tab-separator 'wave)
(setq tabbar-ruler-fancy-tab-separator 'bar)

change with commit 2d0856f https://gist.github.com/9e4e9fca3e1f2d50ddd8 full file with changes. https://gist.github.com/9e215287397e0cf48950

mattfidler commented 8 years ago

Firefox style:

(setq tabbar-ruler-style 'firefox)

image

Still not sure why, but when I use a solarized light theme, there is some padding that doesn't belong.

image

Text style:

(setq tabbar-ruler-style 'text)

image

Therefore the default is still text.

rhoit commented 8 years ago

wow! new theme firefox :+1: that's one heck of awesome changes!

mattfidler commented 8 years ago

Last update for awhile; Use mode-icons

image

rhoit commented 8 years ago

wow, mod icons! now its look damn awesome! my friends are super excited!

screenshot71

here is my screenshot

screenshot73

mattfidler commented 8 years ago

Thanks.