Lost *messages* buffer due to grouping through tabbar-ruler

[boudiccas]

I've been using tabbar and tabbar-ruler for several years with no major problems, until now!

This part of my config specifically relates to tabbar and tabbar-ruler

*** FIXIT tabbar-ruler

#+begin_src emacs-lisp
(setq tabbar-ruler-global-tabbar t)
(require 'tabbar-ruler)
(setq tabbar-buffer-groups-function 'tabbar-buffer-groups) ;; this is the problem line
(global-set-key (kbd "C-c t") 'tabbar-ruler-move)
(mode-icons-mode -1)
(tabbar-mode 1)

(setq tabbar-ruler-background-color "gray12") ;; the color of the tabbar background
#+end_src
[2016-02-16 Tue 06:57]
[2016-04-26 Tue 06:42]
[2016-05-27 Fri 15:22]
[2016-07-29 Fri 06:43]
[2017-01-17 Tue 12:31]
[2018-02-14 Wed 09:34]
[2018-08-27 Mon 15:22]

https://github.com/mattfidler/tabbar-ruler.el

*** tabbar-fix

#+begin_src emacs-lisp
(advice-add 'tabbar-buffer-tab-label :before-until
   (lambda (tab)
    (with-current-buffer (buffer-name (tabbar-tab-value tab))
    (when (equal major-mode 'org-agenda-mode)
           "Agenda"))))
#+end_src
[2016-04-04 Mon 18:47]
[2017-01-17 Tue 12:31]

Now with my current setup i have not got a Messages buffer, however, if I comment out this line

(setq tabbar-buffer-groups-function 'tabbar-buffer-groups)

then I have a Messages buffer, but no tabs displayed by groups, which is my preferred way of using them.

So how can I have a Messages buffer, as well as grouping of my tabs please?

I have used bug-hunter-file in interactive mode to discover where the problem, lies, and it says that my problem line is the source of me not having a Messages buffer. and in my experiments, this is borne out as true.

[rhoit]

its not the fix but this is how I access

 (define-key global-map (kbd "<header-line> <mouse-3>") 'mouse-buffer-menu)

related to #51