search

mattgallagher / AudioStreamer

A streaming audio player class (AudioStreamer) for Mac OS X and iPhone.
http://cocoawithlove.com
1.93k stars 553 forks source link

replaced #ifdef TARGET_OS_IPHONE with #if TARGET_OS_IPHONE #28

Closed kirbyt closed 12 years ago

kirbyt commented 13 years ago

Hi Matt,

TargetConditionals.h header for Mac 10.6 SDK defines TARGET_OS_IPHONE as 0. This means if you compile AudioStreamer against 10.6 it will attempt to compile the iOS specific code. I changed #ifdef TARGET_OS_IPHONE to #if TARGET_OS_IPHONE so the code will build using the Mac 10.6 SDK.

Also, using #if TARGET_OS_IPHONE is recommended by Apple in the Compiling Source Code Conditionally for iOS Applications section of the iOS Development Guide (http://bit.ly/fShoE0).

By the way, thanks for sharing AudioStreamer. It is really useful.

-KIRBY

mattgallagher commented 12 years ago

The #if TARGET_OS_IPHONE was independently implemented. Other changes don't appear to be relevant to general repository.

kirbyt commented 12 years ago

Whoa! My bad. Those other changes were not supposed to be part of the pull request. Guess I need to read up on pull requests and make sure I do them right going forward. Thanks.