search

mattgodbolt / jsbeeb

Javascript BBC micro emulator
GNU General Public License v3.0
351 stars 68 forks source link

Teletext `,` char is wrong #447

Closed tom-seddon closed 2 months ago

tom-seddon commented 2 months ago

I'm not set up to produce PRs for jsbeeb right now, but this is hopefully not too complicated a fix: the bitmap for teletext , needs moving down by one scanline.

Photo from real Master 128:

image

Screen grab from jsbeeb:

image

Note relative placement of bottom of , and the horizontal line in the 4. (I couldn't figure out how to type a @ in jsbeeb on my US keyboard!)

mattgodbolt commented 2 months ago

Oh! Thank you tom!

mattgodbolt commented 2 months ago

(@ is on the backtick ``` key fwiw)!

image

mattgodbolt commented 2 months ago

Tom points out that I moved the whole thing down, but there's an issue; the top dots need to stay in the same place.

Also; @ 's tail is too long and the colon has the same problem.

Maybe worth scraping this: image

tom-seddon commented 2 months ago

FWIW the changes to b2 for ;, : and @ are in this commit: https://github.com/tom-seddon/b2/commit/4e6170c855b531e614f1bfb61b32ac8726944f34