search

mattgodbolt / seasocks

Simple, small, C++ embeddable webserver with WebSockets support
BSD 2-Clause "Simplified" License
734 stars 120 forks source link

Export targets and add zlib to link interface. #108

Closed iwanders closed 5 years ago

iwanders commented 5 years ago

The first commit adds an export statement to the CMakeLists, this creates a SeasocksConfig.cmake file in the build directory. Other cmake projects can then be pointed at this build directory to find the Seasocks target without having to install it. For example:

build/seasocks$ cmake ../../seasocks/ && make
build/project$ Seasocks_DIR=../seasocks/ cmake ../../project/  && make

The second commit adds zlib to the link interface of the static seasocks library. Without this we end up with missing symbols when the static library is used and deflate support is enabled. In the Seasocks unit tests this worked because that manually linked against ${ZLIB_LIBRARIES}. By putting this requirement in the link interface all consumers of the static library will correctly link against this without having to specify ${ZLIB_LIBRARIES}.

Thanks for making Seasocks :+1:

codecov[bot] commented 5 years ago

Codecov Report

Merging #108 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   39.23%   39.23%           
=======================================
  Files          41       41           
  Lines        2039     2039           
=======================================
  Hits          800      800           
  Misses       1239     1239

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33f6537...12edb16. Read the comment docs.