search

mattgodbolt / seasocks

Simple, small, C++ embeddable webserver with WebSockets support
BSD 2-Clause "Simplified" License
724 stars 120 forks source link

This is a Linux Specific Library #123

Closed yck011522 closed 5 years ago

yck011522 commented 5 years ago

Hi, Thanks for creating and maintaining this library.

It would be nice if you can add the warning in the front page of the code base to warn: "This is a Linux Specific Library, It will not compile on a windows machine."

I have spend 30 mins of frustration before I found the thread: As has been concluded here: https://github.com/mattgodbolt/seasocks/issues/23 I'm cool with it. But a warning message is all it needs for a future user to avoid the same agony.

hoytech commented 5 years ago

On the tutorial it says:

It'll only likely work on Linux,

but I agree this should be front and centre on the README so people don't waste time if they're not on linux (sorry about that).

BTW: I wonder if it does work on windows now that there is a compat layer called WSL.

offa commented 5 years ago

First try: #124

BTW: I wonder if it does work on linux now that there is a compat layer called WSL.

Or using eg. Cygwin, Mingw or Msys?

Bokjan commented 5 years ago

sesocks works well with WSL (tested on WSL Ubuntu).

offa commented 5 years ago

Should we include this info in the readme?

Bokjan commented 5 years ago

Not really necessary, I suppose. WSL just translates syscalls to Windows APIs, and for users, it acts like a real Linux in common scenarios.

offa commented 5 years ago

Readme is updated.

offa commented 5 years ago

I guess we can close here, feel free to reopen, if there's anything missing.