mattgodbolt / seasocks

Simple, small, C++ embeddable webserver with WebSockets support
BSD 2-Clause "Simplified" License
724 stars 120 forks source link

Fix builds for older GCCs #175

Closed mattgodbolt closed 1 year ago

mattgodbolt commented 2 years ago

Not sure if we want to keep this or just drop support for them. But see #174

codecov[bot] commented 2 years ago

Codecov Report

Merging #175 (77b9e9b) into master (025ff68) will decrease coverage by 0.58%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   34.65%   34.07%   -0.59%     
==========================================
  Files          53       49       -4     
  Lines        2323     2257      -66     
  Branches      354      336      -18     
==========================================
- Hits          805      769      -36     
+ Misses       1429     1408      -21     
+ Partials       89       80       -9     
Impacted Files Coverage Δ
src/main/c/seasocks/WebSocket.h 25.00% <0.00%> (-15.00%) :arrow_down:
src/main/c/internal/HeaderMap.h 80.00% <0.00%> (-5.72%) :arrow_down:
src/main/c/seasocks/Logger.h 6.25% <0.00%> (-5.52%) :arrow_down:
src/main/c/internal/ConcreteResponse.h 84.61% <0.00%> (-2.89%) :arrow_down:
src/main/c/Connection.cpp 17.50% <0.00%> (-0.44%) :arrow_down:
src/main/c/seasocks/util/Json.h 87.20% <0.00%> (-0.15%) :arrow_down:
src/main/c/seasocks/util/Html.h 98.50% <0.00%> (-0.03%) :arrow_down:
src/main/c/seasocks/Server.h 0.00% <0.00%> (ø)
src/main/c/seasocks/Request.h 100.00% <0.00%> (ø)
src/main/c/internal/Base64.cpp 100.00% <0.00%> (ø)
... and 22 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

offa commented 2 years ago

We can download the latest version from CMake website instead of relying on the version of the package sources.

Update: —> #176

offa commented 1 year ago

See #174