search

mattgodbolt / seasocks

Simple, small, C++ embeddable webserver with WebSockets support
BSD 2-Clause "Simplified" License
734 stars 120 forks source link

Fix/migl/162 #178

Open linkjumper opened 2 years ago

linkjumper commented 2 years ago

see https://github.com/mattgodbolt/seasocks/issues/162

codecov[bot] commented 2 years ago

Codecov Report

Merging #178 (5e7d92c) into master (025ff68) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   34.65%   34.59%   -0.06%     
==========================================
  Files          53       53              
  Lines        2323     2327       +4     
  Branches      354      356       +2     
==========================================
  Hits          805      805              
- Misses       1429     1432       +3     
- Partials       89       90       +1
Impacted Files Coverage Δ
src/main/c/Connection.cpp 17.85% <0.00%> (-0.10%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

madebr commented 2 years ago

Does this pr also block using %2e%2e instead of ..?

linkjumper commented 2 years ago

Does this pr also block using %2e%2e instead of ..?

URL decoding is not implemented: /%2E%2E%/etc/passwd would be caught on line 1230 and returned as 404.