mattgodbolt / seasocks

Simple, small, C++ embeddable webserver with WebSockets support
BSD 2-Clause "Simplified" License
734 stars 120 forks source link

Fix x86 build #192

Closed chausner closed 1 year ago

chausner commented 1 year ago

This fixes compiler warnings treated as errors when compiling for x86 on Windows:

D:\buildtrees\seasocks\src\v1.4.5-50543c2dd9.clean\src\main\c\seasocks\StreamingResponse.cpp(54): error C2220: the following warning is treated as an error D:\buildtrees\seasocks\src\v1.4.5-50543c2dd9.clean\src\main\c\seasocks\StreamingResponse.cpp(54): warning C4244: 'argument': conversion from 'std::streamsize' to 'size_t', possible loss of data

D:\buildtrees\seasocks\src\v1.4.5-50543c2dd9.clean\src\main\c\HybiPacketDecoder.cpp(86): error C2220: the following warning is treated as an error D:\buildtrees\seasocks\src\v1.4.5-50543c2dd9.clean\src\main\c\HybiPacketDecoder.cpp(86): warning C4244: '=': conversion from 'uint64_t' to 'size_t', possible loss of data

codecov[bot] commented 1 year ago

Codecov Report

Merging #192 (33f7d9f) into master (7155ad2) will not change coverage. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   34.84%   34.84%           
=======================================
  Files          54       54           
  Lines        2330     2330           
  Branches      355      355           
=======================================
  Hits          812      812           
  Misses       1429     1429           
  Partials       89       89           
Files Changed Coverage Δ
src/main/c/seasocks/StreamingResponse.cpp 0.00% <0.00%> (ø)
src/main/c/HybiPacketDecoder.cpp 73.43% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

offa commented 1 year ago

Thank you!

offa commented 1 year ago

Released as v1.4.6.