search

mattgodbolt / zindex

Create an index on a compressed text file
BSD 2-Clause "Simplified" License
620 stars 37 forks source link

add flag to log warnings to info #27

Closed sbendiola closed 7 years ago

mattgodbolt commented 7 years ago

So it looks cool; but wouldn't a similar effect be achieved by setting the log level to "error" ? Or is the problem the log to stderr itself? You could always run with zindex ... 2>&1 or similar if that works? Or maybe we should just make the one warning that's causing issue an info?

sbendiola commented 7 years ago

It's the logging to stderr that's causing the problem. The original message was warning when it was rebuilding the index causing my cron job to report an error

On Thu, Dec 8, 2016, 1:17 PM Matt Godbolt notifications@github.com wrote:

So it looks cool; but wouldn't a similar effect be achieved by setting the log level to "error" ? Or is the problem the log to stderr itself? You could always run with zindex ... 2>&1 or similar if that works? Or maybe we should just make the one warning that's causing issue an info?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mattgodbolt/zindex/pull/27#issuecomment-265828430, or mute the thread https://github.com/notifications/unsubscribe-auth/AADAWdSroqJR0L0CRDgsJiw5tkZ0KFWgks5rGFe-gaJpZM4LIIKX .

mattgodbolt commented 7 years ago

Got it: you don't want warnings to look "errrory" in this context. Makes sense. I'd prefer the switch to just control whether the warnings went to stderr in that case: they're still warnings.