search

mattgoldspink / grunt-sencha-dependencies

Grunt task to get the list of Ext.require dependencies in your application
MIT License
32 stars 22 forks source link

Fixing path issues for Windows when starting phantomjs #33

Closed sondremare closed 10 years ago

sondremare commented 10 years ago

A problem occured when phantomjs spawned on windows. It would include script tags with the wrong relative source.

mattgoldspink commented 10 years ago

Thanks for the pull request @sondremare. Before I merge it could you explain to me a little more about the issue you saw? For example what was the path that had an issue? How did it appear in the script tags and what were you actually expecting it to be?

sondremare commented 10 years ago

Here are the options we run with: options: { pageRoot: './src', // relative to dir where grunt will be run appJs: 'app.js', // relative to www senchaDir: '../vendor/touch', includeAllScriptTags: false, exclude: ['settings.js', 'messages.js'] }

Script tag generated on Linux and Mac is: "script src='../vendor/touch/sencha-touch-debug.js'", but on windows its "script src='../sencha-touch-debug.js'".

This is due to the "turnUrlIntoRelativeDirectory" being unable to resolve "url.lastIndexOf("/")".

sondremare commented 10 years ago

Great, thanks :)

Vennlig hilsen Sondre Mære Overskaug Systemansvarlig, Corporate Mobile Self Service Corporate

sondre.mere.overskaug@evry.com M +47 451 86 579

Den 14. mars 2014 kl. 13:25 skrev Matt Goldspink notifications@github.com:

Merged #33.

— Reply to this email directly or view it on GitHub.