search

mattgoldspink / grunt-sencha-dependencies

Grunt task to get the list of Ext.require dependencies in your application
MIT License
32 stars 22 forks source link

Phantom 1.9.0-6 cannot be installed #40

Closed jjmr closed 7 years ago

jjmr commented 8 years ago

Npm dependency of Phantomjs with version 1.9.0-6 tries to download the binary from an unexistent url (an out of date url of googlecode). To solve this problem, phantomjs version should be increased in the package.json of the gtunt-sencha-dependencies.

andrei-ivanov commented 7 years ago

Same problem here... Seems that this project is abandoned :-(

mattgoldspink commented 7 years ago

@jjmr @andrei-ivanov Hey guys - the project isn't completely abandoned! However I don't use it any more since I'm not doing any Sencha dev work. However I'd be more than happy to accept any pull requests that fix this, so feel free to submit one and I'll merge and update the project.

andrei-ivanov commented 7 years ago

@mattgoldspink That's good news :) I've just started working with these technologies on a project that's in maintenance mode and I ran into this issue. Since I cannot upgrade to the latest versions (PhantomJS 2.x), I thought of just upgrading the deps to the latest 1.9 versions available. I hope it's fine.

andrei-ivanov commented 7 years ago

I've sent the PR, not sure if you've been notified :)

andrei-ivanov commented 7 years ago

@mattgoldspink hello?

mattgoldspink commented 7 years ago

HI @andrei-ivanov - Sorry for the delay. You caught me in the middle of 36 hours of flights. I'll aim to take a look at merging and updating npm over the weekend for you.

andrei-ivanov commented 7 years ago

@mattgoldspink Great :)

mattgoldspink commented 7 years ago

@andrei-ivanov version 0.9.0 is now available with this fix on NPM - https://www.npmjs.com/package/grunt-sencha-dependencies

andrei-ivanov commented 7 years ago

@mattgoldspink that is awesome, I can confirm it is working now :-) Thank you very much.