search

mattgrayisok / craft-dark-mode

Dark Mode for Craft CMS
MIT License
13 stars 2 forks source link

Feature request, add an auto mode for prefers-color-scheme #11

Closed riasvdv closed 5 years ago

riasvdv commented 5 years ago

As per this post https://paulmillr.com/posts/using-dark-mode-in-css/ it would be nice to have it change depending on the preference of the user.

mattgrayisok commented 5 years ago

Thanks for the suggestion. I'm currently trying to figure out how to nicely integrate this with an additional manual switch in the CP. Also the complication of carrying the user's preference as set in the CP between different login devices vs the presence of this dark mode opt-in.

mattgrayisok commented 5 years ago

@Rias500 I decided to add a simple switch to the control panel with local storage persistence in v1.1.0 rather than try to combine logic for both OS level preference and app level preference.

It's a slight annoyance having to flick the switch when you already have dark mode enabled in MacOS but it only needs doing once and saves on complexity.

Hope that works for your use case 🤞