search

mattgrill / drupal-react-dblog

18 stars 8 forks source link

Multi select list behavior #9

Closed tesliker closed 6 years ago

tesliker commented 6 years ago

The Multi select list has a few issues that I would not expect. When I choose a second item, it keeps the old selection as well without me holding the command or ctrl key. Also, after I select an item, I cannot unselect it if it is the last one left. This might be a "feature", but it is confusing to me.

tesliker commented 6 years ago

I can see the usefulness of the first feature where clicking just adds to the list, but I think users should be able to unselect the only selected item. The reason this immediately came up is because I select an item and all dblog errors disappeared, so I wanted to go back and see what kind of errors I have.

tesliker commented 6 years ago

Easy fix for me was changing the changeHandler function of the select component to run onClick

tesliker commented 6 years ago

This was addressed in PR #11, Select lists now function normally.

dawehner commented 6 years ago

@tommy sliker Thank you for closing!

On Tue, 5 Dec 2017 at 17:56 Tommy Sliker notifications@github.com wrote:

Closed #9 https://github.com/mattgrill/drupal-react-dblog/issues/9.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mattgrill/drupal-react-dblog/issues/9#event-1373189804, or mute the thread https://github.com/notifications/unsubscribe-auth/AABz7soy47-raZf4b4rYM2kUDYKX-Tprks5s9YOkgaJpZM4QywEy .