mattharrison / effective_xgboost_book

268 stars 30 forks source link

Discrepancy in Decision Tree Node Visualizations in the Book #13

Open FutureGoose opened 11 months ago

FutureGoose commented 11 months ago

Hello Matt Harrison,

I've been enjoying your book so far. However, I noticed some inconsistencies in the decision tree visualizations, specifically on page 53. While this seems to occur in multiple nodes, I'd like to highlight the first node to the right as an example.

Issue:

The sum of the class distribution values is 1026, which doesn't match the 673 samples reported for that node.

Potential Impact:

These discrepancies could lead to confusion for readers and impact the overall understanding of decision trees presented in the book.

Suggestion:

It might be beneficial to revisit the visualization process or the underlying data/model to ensure the accuracy of the visual representations.

I genuinely appreciate your work on this book, and I hope this feedback contributes to its ongoing refinement. Please let me know if you need further details.

Thank you and best regards, Goose