search

mattharrison / effective_xgboost_book

271 stars 30 forks source link

Minor: 3.2 bar plots - kag_y vs kag_y_train #20

Open Offroadpia opened 3 hours ago

Offroadpia commented 3 hours ago

I believe that pd.crosstab(index=X_train['major_cs'], columns=kag_y) should read pd.crosstab(index=X_train['major_cs'], columns=kag_y_train)

Thanks

mattharrison commented 2 hours ago

Yes, you are technically correct. However, this should never matter because of it does our data is messed up.

On Sat, Oct 26, 2024, 10:36 AM Offroadpia @.***> wrote:

I believe that pd.crosstab(index=X_train['major_cs'], columns=kag_y) should read pd.crosstab(index=X_train['major_cs'], columns=kag_y_train)

Thanks

— Reply to this email directly, view it on GitHub https://github.com/mattharrison/effective_xgboost_book/issues/20, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA5E3P2IKLDWTBM2DJDAUDZ5PHKLAVCNFSM6AAAAABQU7UDJWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYYTMMBSGM3TKMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>