search

mattharrison / rst2odp

Create OpenOffice.org (impress) slideshows from restructured text (rst) or python
MIT License
27 stars 16 forks source link

Corrupt odp files in libreoffice 3.5 with headrevs #8

Closed clach04 closed 12 years ago

clach04 commented 12 years ago

Using the README.rst and the current version (with Py 2.4 and elementtree-1.2.6-20050316) rst2odp runs but the generated file is marked as corrupt. File also shows up as corrupted in Microsoft Office 2007. LibreOffice 3.5 can recover the file.

The file is a valid zip file (test operation in an archiver such h as 7z works).

The recovered file in LO is also missing meta data (this may be a separate bug)

clach04 commented 12 years ago

Not sure this is relevant but just in case, I do NOT have pygments installed.

mattharrison commented 12 years ago

I need more info. Are you opening odp with MS Office directly? (I don't even have a windows partition so I can't help with that). I haven't had any issues with OOo 3+ and LO 3+.

clach04 commented 12 years ago

I'm using LO 3.5 (just downloaded today) under Windows LibO_3.5.3_Win_x86_install_multi.msi.

The MS Office check was a sanity check :-)

Is it worth me emailing the odp generated? I can;t see a way to have attachments to issues in github.

mattharrison commented 12 years ago

If it works in LO or OOo, it's unlikely I'll do anything. Probably best to create a simple rst that recreates the problem and I can make a test for it.

mattharrison commented 12 years ago

BTW, I hope you don't take my responses to be rude. I'd love others to enjoy using rst2odp, it's just currently developed under the auspices of what itches I want to scratch. I've been using it successfully for many years, though understand that others might have issues with it.

clach04 commented 12 years ago

It does not work in LO (I've not checked OOo yet). The test case is the README.rst with rst2odp.

mattharrison commented 12 years ago

Thanks for the clarification. I've never actually tried running the README.rst, so I don't claim that it is supported :) (Though it probably should be handled). docs/intro.rst shows most of the current functionality.

clach04 commented 12 years ago

BTW, I hope you don't take my responses to be rude

Not at all, I'm appreciate of you making this available and the quick responses!

I think the issues I'm raising are for "bad" input scenarios (apart from this one this issue is weird)

mattharrison commented 12 years ago

Not necessarily bad input. Ideally rst2odp should support the full gamut of rst that docutils offers. Sadly, I haven't felt the need to implement the full spec. Hence the errors about NotImplemented... I could silence those (which might be nicer for end users), but that wouldn't allow nice folks such as yourself to tell me that you are actually interested in said functionality.

clach04 commented 12 years ago

I've not yet worked out what is going in yet BUT testing with Py 2.5 works, using 2.4 (and old ElementTree) does not work.

Moving to Py 2.5 creates valid odp files.

clach04 commented 12 years ago

Hard to say if this is a py2.4 or rst2odp bug, fixed in rst2odp https://github.com/mattharrison/rst2odp/pull/12