search

matthew-andrews / isomorphic-fetch

Isomorphic WHATWG Fetch API, for Node & Browserify
MIT License
6.95k stars 289 forks source link

Update node-fetch to `^2.0.0` (major change) #157

Closed leoselig closed 3 years ago

leoselig commented 6 years ago

This will change the behavior of isomorphic-fetch if imported in a Node.js environment. The actual major changes can be found in the 2.0.0 release notes of node-fetch. See: https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md#v200

Overall, this should increase the usefulness of isomorphic-fetch by a lot since version 2 aligns the implementation with the spec for a lot of issues. For instance, I expect this to fix:

leoselig commented 6 years ago

That error confuses me. Why is it checking files in the dependencies? Is that intentional?

dbkaplun commented 6 years ago

Any word on this?

znarf commented 6 years ago

@leoselig Thank you for contributing this PR. That would be really great to have.

IanVS commented 6 years ago

I'd love to have headers.entries(). But it seems like maybe isomorphic-fetch is dead / unmaintained? There hasn't been a release in a very long time...

hulkish commented 6 years ago

@matthew-andrews Would like to see this land. Can you release this, please?

styfle commented 6 years ago

There have been several new releases since 2.0.0 Maybe update this PR to "node-fetch": "^2.2.0"

codler commented 5 years ago

I started on new fetch which uses node-fetch 2.x https://github.com/codler/fetch-register

yordis commented 5 years ago

@matthew-andrews could you support us with this issue, please.

jacktuck commented 5 years ago

v1 is not spec compliant in regards to utf-8, please can we land this?

https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md#response-and-request-classes

matthew-andrews commented 3 years ago

This has been resolved in master … sorry for the huge delay. I will release as a major version soon, please test against your applications.