search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

MRG: fix for docstring #124

Closed matthew-brett closed 2 years ago

matthew-brett commented 2 years ago

I played with *args and **kwargs to warn on positional arguments here, but all the solutions looked like they would make type-hinting more obscure, so I gave up.

We can just raise an error for non-keyword arguments later. It's a pretty obvious fix for our users.

codecov-commenter commented 2 years ago

Codecov Report

Merging #124 (a9b5dca) into master (dbb9367) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          13       13           
  Lines         999      999           
=======================================
  Hits          948      948           
  Misses         51       51
Impacted Files Coverage Δ
delocate/delocating.py 97.63% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbb9367...a9b5dca. Read the comment docs.