matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

Add Black and isort formatters. #129

Closed HexDecimal closed 2 years ago

HexDecimal commented 2 years ago

I've added Black and isort to the workflows and formatted the code with them. When this is merged I'll no longer have to micromanage formatting and import order.

I wanted this to just be the reformatting and the config files but I had to replace some lambdas to fix warnings with Flake8. I put off other changes I could have made so that this PR can be simpler.

I've added a .git-blame-ignore-revs file which can be used to ignore Black's sweepings changes when checking blames.

I've also uploaded my current VSCode workspace settings. Which enforces an 80-column ruler and automatically formats scripts on saving.

codecov-commenter commented 2 years ago

Codecov Report

Merging #129 (bf31fda) into master (fe797b5) will increase coverage by 0.20%. The diff coverage is 94.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   95.07%   95.28%   +0.20%     
==========================================
  Files          13       13              
  Lines         995     1018      +23     
==========================================
+ Hits          946      970      +24     
+ Misses         49       48       -1     
Impacted Files Coverage Δ
delocate/cmd/delocate_patch.py 84.37% <75.00%> (+0.50%) :arrow_up:
delocate/cmd/delocate_addplat.py 83.92% <85.71%> (+0.59%) :arrow_up:
delocate/cmd/delocate_path.py 83.33% <87.50%> (ø)
delocate/tools.py 94.85% <88.09%> (+0.04%) :arrow_up:
delocate/wheeltools.py 99.08% <96.87%> (+0.03%) :arrow_up:
delocate/delocating.py 98.14% <97.29%> (+0.51%) :arrow_up:
delocate/__init__.py 100.00% <100.00%> (ø)
delocate/cmd/delocate_fuse.py 86.95% <100.00%> (+0.59%) :arrow_up:
delocate/cmd/delocate_listdeps.py 92.85% <100.00%> (+0.17%) :arrow_up:
delocate/cmd/delocate_wheel.py 93.18% <100.00%> (+0.15%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe797b5...bf31fda. Read the comment docs.