search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
266 stars 58 forks source link

Replicate the to-be-removed `wheel.pkginfo` module. #136

Closed HexDecimal closed 2 years ago

HexDecimal commented 2 years ago

The plans to remove the wheel.pkginfo module can be negotiated with the wheel devs, but this PR should cause less drama.

Adds delocate.pkginfo to read/write these files, based on the original module.

Removes code supporting wheel<0.32.0. Adds code to support the unreleased versions of wheel>0.37.1.

Adds type hinting to the relevant functions.

Closes #135

matthew-brett commented 2 years ago

Worth also copying the test_pkginfo.py test?

HexDecimal commented 2 years ago

Worth also copying the test_pkginfo.py test?

I thought of that, but looking at the test and the code, the test is just making sure that email.generator works rather than anything more specific to the function itself.

All 3 functions are covered by other tested functions which rely on them.

matthew-brett commented 2 years ago

OK - nice - thanks for doing that so fast.