search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

Remove dependencies on wheels unstable API. #141

Closed HexDecimal closed 2 years ago

HexDecimal commented 2 years ago

Based on feedback from https://github.com/pypa/wheel/issues/433. There are plans on refactoring wheel which will likely break Delocate again. This PR will prevent that from happening.

Small single-used wheel functions are now inline. The packaging module was added which has a stable API for parsing wheel names. Type hinting added to relevant functions.

matthew-brett commented 2 years ago

Thanks - looks good to me. Would you mind merging when CI passes?

HexDecimal commented 2 years ago

Would you mind merging when CI passes?

TravisCI seems to timeout before it can run. I also can't manually re-run those jobs on a PR.

HexDecimal commented 2 years ago

I guess the question is should I merge this when TravisCI has timed out and what's going to be done about TravisCI in the long term since it only seems to become more unreliable?

matthew-brett commented 2 years ago

Yes, please do merge after rebase (looks like).

And for Travis-CI - yes - we should plan to drop it as soon as possible. One of us should go through and check, record what we are losing, when we do - I will have a chance to do that next week if you can't get to it before.