search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

Use future annotations. #160

Closed HexDecimal closed 1 year ago

HexDecimal commented 1 year ago

The previous merges caused a logical conflict.

Since Python 3.7 is now the lowest version, type hints can now be deferred outside of runtime. This fixes the error with subprocess.CompletedProcess[str] which is not available at runtime on older Python versions.

I'm merging this as soon as tests pass.

codecov-commenter commented 1 year ago

Codecov Report

Merging #160 (78be3d7) into master (97a488c) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   95.44%   95.45%           
=======================================
  Files          14       14           
  Lines        1076     1077    +1     
=======================================
+ Hits         1027     1028    +1     
  Misses         49       49
Impacted Files Coverage Δ
delocate/tools.py 96.12% <100.00%> (+0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more