search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

Option to sanitize rpaths #164

Closed isuruf closed 7 months ago

isuruf commented 1 year ago

Fixes https://github.com/matthew-brett/delocate/issues/101

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (082ab1e) 95.11% compared to head (ccc82a1) 95.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #164 +/- ## ========================================== + Coverage 95.11% 95.21% +0.10% ========================================== Files 15 15 Lines 1167 1192 +25 ========================================== + Hits 1110 1135 +25 Misses 57 57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PhilipGarnero commented 7 months ago

Can we merge this ? Work seems good to me. Even if deemed not perfect, it's more useful than nothing. A click on the merge button please ! 🙇‍♂️

HexDecimal commented 7 months ago

The fakepkg_rpath wheel adds lib/ to its rpaths to more easily link its libraries with delocate, but it's not what you'd want in a post-delocated wheel so I've added a test which sanitizes it away.

I've edited this PR so that only @executable_path/ and @loader_path/ are allowed when sanitizing. Which I think is what's expected but it's hard to tell.