search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

it would be nice if delocate-fuse would rename its output #174

Open glyph opened 1 year ago

glyph commented 1 year ago

Is your feature request related to a problem? Please describe. delocate-fuse creates a universal2 wheel (which is amazing) but gives it the wrong tag

Describe the solution you'd like Do not rewrite the input in place, instead, put a wheel next to it with a modified tag name.

Describe alternatives you've considered It is not clear to me what other behavior would be correct :)

Additional context I'm not sure if this is a feature or a bug. It strikes me as incorrect behavior to write an x86_64 tagged wheel that has arm64 code in it, but I am filing it as an enhancement as I assume the existing behavior has some reason for existing.

matthew-brett commented 1 year ago

I'm afraid the reason it hasn't changed is because - it started that way. Would you be interested in changing it to give the correct tag instead, with a --retag optional flag to trigger that behavior (for back-compatibility)?

henryborchers commented 8 months ago

@matthew-brett I'd think you'd want renaming to be the default. When you create a universal2 wheel, it's until it's properly named, it is useless at as best and harmful at worst because it no longer reflects the contents of the wheel correctly. If someone wants the existing behavior, they should opt in, not the other way. Even if this is a breaking chance for some scripts.

Doondondon commented 7 months ago

Is your feature request related to a problem? Please describe. delocate-fuse creates a universal2 wheel (which is amazing) but gives it the wrong tag

Describe the solution you'd like Do not rewrite the input in place, instead, put a wheel next to it with a modified tag name.

Describe alternatives you've considered It is not clear to me what other behavior would be correct :)

Additional context I'm not sure if this is a feature or a bug.