search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
266 stars 58 forks source link

Use exact directory name to decide dylib files directory #194

Closed HexDecimal closed 9 months ago

HexDecimal commented 10 months ago

Replaces directory.endswith(package_name) with the more exact Path(directory).name == package_name.

I didn't find any other determinism issues in this function.

I think find_package_dirs shouldn't have returned a set, since it operates on os.listdir it should've returned a list instead, but that doesn't really matter

Fixes #192

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fbefb81) 95.19% compared to head (ae4d077) 95.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #194 +/- ## ======================================= Coverage 95.19% 95.19% ======================================= Files 15 15 Lines 1186 1187 +1 ======================================= + Hits 1129 1130 +1 Misses 57 57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwoehlke-kitware commented 9 months ago

Looks sane here, FWIW. Thanks for the fix!