Expand globs in simple script arguments

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels

BSD 2-Clause "Simplified" License

267 stars 59 forks source link

Expand globs in simple script arguments #197

Closed HexDecimal closed 11 months ago

HexDecimal commented 11 months ago

Expands globs in simple cases using the following rules:

If any path is a existing folder or file then it's used as-is, even if it can be used as a glob pattern. This is supposed to ensure that there's no surprises or regressions.
Otherwise the glob is expanded with Python's glob module. If this results in no files then it raises FileNotFoundError.

Added tests for this.

Some commands are too complex for this workaround. This only applies to commands which takes one list of arguments and not commands with more complex positional parameters such as delocate-fuse and delocate-patch.

I'd rather not merge this PR until it's reviewed.

Fixes #71

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a17dc82) 96.40% compared to head (62f0a50) 96.45%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #197 +/- ## ========================================== + Coverage 96.40% 96.45% +0.04% ========================================== Files 15 15 Lines 1169 1184 +15 ========================================== + Hits 1127 1142 +15 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HexDecimal commented 11 months ago

After some more thought and better tests I've decided that this shouldn't cause issues when merged. Preferring literal names to glob expansion should avoid theoretical regressions, and this PR is very easy to revert if any unexpected edge cases do appear.