search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
268 stars 59 forks source link

Fix deleting duplicated rpaths #208

Closed isuruf closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.80%. Comparing base (43ad6b3) to head (9b59f36).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #208 +/- ## ========================================== - Coverage 96.80% 96.80% -0.01% ========================================== Files 15 15 Lines 1285 1283 -2 ========================================== - Hits 1244 1242 -2 Misses 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

isuruf commented 8 months ago

Sorry, didn't see your edit. Shall I revert the Counter changes?

isuruf commented 8 months ago

Thanks @HexDecimal for the reviews.

isuruf commented 8 months ago

@HexDecimal is there a release planned for delocate?

HexDecimal commented 8 months ago

I'm slightly hesitant with the recent changes and the changes I've been considering, but nothing is actually preventing a release it in its current state. I'll do a release now. I probably should've done one earlier.