search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

If wheel has no package directories, use lib_sdir as a suffix #210

Closed skirpichev closed 3 weeks ago

skirpichev commented 3 months ago

Currently, there is no way to customize libs dir if the wheel has no package directory.

One use case is an extension, that offers C-API (like the gmpy2 package). With above patch you could set one to something common for all platforms.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (7f46f89) to head (a95f96c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #210 +/- ## ======================================= Coverage 96.93% 96.93% ======================================= Files 16 16 Lines 1307 1307 ======================================= Hits 1267 1267 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HexDecimal commented 3 weeks ago

Sorry for taking so long to respond. I've rebased the PR, updated a test, and documented the feature better. I think your implementation fits well with the existing API.