matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
262 stars 59 forks source link

fix string formatting in error message #216

Closed jameslamb closed 3 weeks ago

jameslamb commented 1 month ago

Thanks for this awesome project!

I noticed tonight that an error message is printing with the literal string f{lib_path} in it, like this:

delocate.libsana.DelocationError: f{lib_path} already exists in wheel but need to copy /opt/homebrew/Cellar/libomp/17.0.6/lib/libomp.dylib

I strongly suspect that was supposed to be an f-string, where {lib_path} is replaced in the error message with a path to a library.

This proposes that fix.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (7f46f89) to head (e4c8b64).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #216 +/- ## ======================================= Coverage 96.93% 96.93% ======================================= Files 16 16 Lines 1307 1307 ======================================= Hits 1267 1267 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HexDecimal commented 3 weeks ago

I apologize for getting around to this PR so late. I've rebased the PR and updated the changelog and the relevant tests. Tests for DelocationError were missing a match= argument.

jameslamb commented 3 weeks ago

No problem, and thanks very much!