search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
268 stars 59 forks source link

Apply suggestions to the deployment workflow #221

Closed HexDecimal closed 2 months ago

HexDecimal commented 4 months ago

I merged #220 too early. @webknjaz has suggested several small tweaks to that PR, this PR applies them. My initial configuration was outdated.

Apologies to @matthew-brett, if you setup any of the optional security stuff with the deploy environment then you should do the same with a pypi environment. If you didn't do any of the extras then apparently the environment will be automatically created on-demand and you won't need to do anything.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (de38e09) to head (67dce42). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #221 +/- ## ======================================= Coverage 96.93% 96.93% ======================================= Files 16 16 Lines 1307 1307 ======================================= Hits 1267 1267 Misses 40 40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.