Open MAKOMO opened 2 months ago
The lib_exts
parameter isn't even used by the caller. This could be replaced with a more reliable filter than the file suffix.
When I check to see what the main analysis function uses, _is_macho_file
shows up again. Could probably use that here.
I can confirm that using _is_macho_file()
fixes the problem.
Describe the bug While delocate-merge succeeds to merge PyQt6-Qt6 arm and x86 wheels the resulting wheel contains Qt Frameworks that are not universal2.
To Reproduce
Expected behavior A full universal2 wheel.
Wheels used If a wheel is involved then consider attaching the original wheel (before being delocated) or linking to the repository where the original wheel can be created.
https://files.pythonhosted.org/packages/7e/9d/517b12a42b0692c909ed348545114dae7d0b4014ef9075e18f6bf48834a1/PyQt6_Qt6-6.7.2-py3-none-macosx_11_0_arm64.whl
https://files.pythonhosted.org/packages/10/38/ba0313442c5e4327d52e6c48d2bb4b39099bf1d191bd872edfd8bb1392ef/PyQt6_Qt6-6.7.2-py3-none-macosx_10_14_x86_64.whl
Platform (please complete the following information):
Additional context
Only files with the extensions
are fused by
fuse_trees
but this Qt Framework binary has no extension at all.Patching
fuse_trees
as follows works for those Qt packages, but is not be general enough to catch other cases.