search

matthew-brett / delocate

Find and copy needed dynamic libraries into python wheels
BSD 2-Clause "Simplified" License
266 stars 58 forks source link

MRG: enforce UTF-8 codec for README #81

Closed matthew-brett closed 4 years ago

matthew-brett commented 4 years ago

Closes #80

haberman commented 4 years ago

Thanks for the quick fix!

Any chance you could put out a patch release for this? I believe this regressed for us in 0.8.1.

matthew-brett commented 4 years ago

It really can't have changed in 0.8.1, because the offending line:

long_description = open('README.rst', 'rt').read()

has been unchanged in Delocate for the past six years. I guess what happened is that your testing images changed to having the (very odd) locale of "ascii". I'm a little surprised that nothing else broke ... But yes, I'll do a little release soon.

matthew-brett commented 4 years ago

Although - thinking about it - it is possible that the README.rst acquired a non-ascii character recently ...

matthew-brett commented 4 years ago

Yes, indeed - that is what happened - the README.rst file acquired a non-ascii character between 0.8.0 and 0.8.1

matthew-brett commented 4 years ago

Done - https://pypi.org/project/delocate/0.8.2/

haberman commented 4 years ago

Thank you, I really appreciate it!