search

matthew-brett / transforms3d

3 dimensional spatial transformations
http://matthew-brett.github.io/transforms3d/
Other
467 stars 83 forks source link

Replace np.float by float following np.float deprecation in numpy 1.20 #39

Closed ericpre closed 3 years ago

ericpre commented 3 years ago

See https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling e2309f062aa1e2330ae84bc2ac6f802709696198 on ericpre:fix_numpy_1.20_warning into 52321496a0d98f1f698fd3ed81f680d740202553 on matthew-brett:master.

adeak commented 3 years ago

This is partly superseded by https://github.com/matthew-brett/transforms3d/pull/41 but there are still three instances of np.float left. @ericpre do you want to update this PR to fix those?

matthew-brett commented 3 years ago

Thanks for this - I've put the changes in directly to master now - so I think this one is superceded - please let me know if you don't agree.

ericpre commented 3 years ago

Yes, that looks good to me!