search

matthew-brett / transforms3d

3 dimensional spatial transformations
http://matthew-brett.github.io/transforms3d/
Other
467 stars 83 forks source link

RF: allow for unnormalized quaternions in axangle #5

Closed matthew-brett closed 8 years ago

matthew-brett commented 9 years ago

quat2axangle previously assumed input quaternions were normalized. Do normalization of the quaternion, and signal various precision-related error conditions.

ignatenkobrain commented 8 years ago

Any news here?

matthew-brett commented 8 years ago

Thanks for the prompt, still hoping for comment, but if not, I will merge.

ignatenkobrain commented 8 years ago

Can we also after unbundle transforms3d from nipy?

matthew-brett commented 8 years ago

That's the question I'm asking Alexis - whether the nipy modifications make sense in general for transforms3d.

ignatenkobrain commented 8 years ago

I think we can merge and unbundle from nipy

matthew-brett commented 8 years ago

Merging this is probably the right thing to do, but this PR would not give the same behavior that nipy currently has, which is why I was asking for feedback.