search

matthew-brett / xibabel

Piloting a new image object for neuroimaging based on XArray
BSD 2-Clause "Simplified" License
6 stars 0 forks source link

Add slice-timing correction experiment #10

Closed effigies closed 5 months ago

effigies commented 7 months ago

Getting a handle on this structure.

It was a little bit counter-intuitive that we use attrs['meta'] instead of attrs. This resulted in a new image containing a shallow copy of the old image's metadata, so popping invalidated metadata removed it from the old image as well as the new.

The clean interactions with scipy are very nice.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6242c65) 76.40% compared to head (97d0ad5) 76.40%.

Files Patch % Lines
src/xibabel/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ======================================= Coverage 76.40% 76.40% ======================================= Files 9 9 Lines 534 534 Branches 77 77 ======================================= Hits 408 408 Misses 110 110 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matthew-brett commented 5 months ago

Yes, we should probably move the metadata to attrs - I was just reflecting on what to about mergeing the BIDS data with stuff that we need. I'll add an issue.