search

matthew-brett / xibabel

Piloting a new image object for neuroimaging based on XArray
BSD 2-Clause "Simplified" License
6 stars 0 forks source link

Refactor JSON load / save in netCDF #8

Closed matthew-brett closed 5 months ago

matthew-brett commented 8 months ago

This makes the JSON storage a bit more obvious in the loaded netCDF file, when loaded not-by-us.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 90.34091% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 84.09%. Comparing base (3509316) to head (c48055e).

:exclamation: Current head c48055e differs from pull request most recent head 2a305bd. Consider uploading reports for the commit 2a305bd to get more accurate results

Files Patch % Lines
src/xibabel/tests/run_server.py 33.33% 17 Missing and 1 partial :warning:
src/xibabel/loaders.py 91.50% 7 Missing and 6 partials :warning:
src/xibabel/tests/conftest.py 96.29% 1 Missing and 1 partial :warning:
src/xibabel/tests/test_loaders.py 99.11% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8 +/- ## ========================================== + Coverage 76.40% 84.09% +7.69% ========================================== Files 9 11 +2 Lines 534 805 +271 Branches 74 111 +37 ========================================== + Hits 408 677 +269 + Misses 110 108 -2 - Partials 16 20 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matthew-brett commented 5 months ago

@effigies - comments here? I've implemented reading of Nibabel images from anything that fsspec can read, I think - and tested reading from HTTP. I guess it should work from AWS / GCS / Azure as well.

matthew-brett commented 5 months ago

Thanks - that does test fine and is neater.

matthew-brett commented 5 months ago

I think this one is ready now - will merge soon unless anyone has any urgent comments.