Closed matthew-brett closed 5 months ago
Attention: Patch coverage is 90.34091%
with 34 lines
in your changes are missing coverage. Please review.
Project coverage is 84.09%. Comparing base (
3509316
) to head (c48055e
).:exclamation: Current head c48055e differs from pull request most recent head 2a305bd. Consider uploading reports for the commit 2a305bd to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@effigies - comments here? I've implemented reading of Nibabel images from anything that fsspec can read, I think - and tested reading from HTTP. I guess it should work from AWS / GCS / Azure as well.
Thanks - that does test fine and is neater.
I think this one is ready now - will merge soon unless anyone has any urgent comments.
This makes the JSON storage a bit more obvious in the loaded netCDF file, when loaded not-by-us.