search

matthewcheok / JSONCodable

Hassle-free JSON encoding and decoding in Swift
MIT License
602 stars 66 forks source link

Use proper SemVer in release version tags #55

Closed mokagio closed 7 years ago

mokagio commented 7 years ago

The tag of each version should use proper Semantic Versioning, or it won't work with tools like Carthage, which expect valid version tags.

For example: the latest version is tagged 3.0. This is not valid SemVer. It should be 3.0.0.

Not sure if it's worth rewriting the current tags, but it's definitely something to keep in mind for the future.

Thanks

mokagio commented 7 years ago

or it won't work with tools like Carthage, which expect valid version tags.

I apologize. It wasn't working due to another issue with my setup, not with how the tag was defined in this repo.

Nevertheless Imho using full SemVer would be more accurate.

Nadohs commented 7 years ago

thanks, glad you were able to get it to work. I will keep that in mind for version going forward.