modifying JSONCodable to include all properties

matthewcheok / JSONCodable

Hassle-free JSON encoding and decoding in Swift

MIT License

602 stars 66 forks source link

modifying JSONCodable to include all properties #63

Closed andyast closed 7 years ago

andyast commented 7 years ago

Added a test to confirm that this doesn’t get broken again.

andyast commented 7 years ago

I had fixed this previously but it appears that in the conversion to swift 3 the change got lost.

Nadohs commented 7 years ago

This looks good to me. If you don't mind fixing the conflicts I will go ahead and merge it in.

andyast commented 7 years ago

conflicts fixed. There are two tests that are failing, but I checked and they were failing prior to this code change. testArrayOfUsers() testDecodingRegular()