matthewcheok / JSONCodable

Hassle-free JSON encoding and decoding in Swift
MIT License
602 stars 66 forks source link

Migrate to Swfit 4 #88

Closed dsame closed 2 years ago

dsame commented 5 years ago

The 1.0.3 failed to build with XCode 10.3

2019-08-31T05:59:49.0319960Z /Users/vsts/agent/2.155.1/work/1/s/Pods/JSONCodable/JSONCodable/JSONDecodable.swift:94:25: warning: 'characters' is deprecated: Please use String directly
2019-08-31T05:59:49.0320100Z         var chars = key.characters
2019-08-31T05:59:49.0320370Z                         ^
2019-08-31T05:59:49.0321000Z /Users/vsts/agent/2.155.1/work/1/s/Pods/JSONCodable/JSONCodable/JSONDecodable.swift:95:27: error: referencing instance method 'popFirst()' on 'Collection' requires the types 'String' and 'String.SubSequence' (aka 'Substring') be equivalent
2019-08-31T05:59:49.0321160Z         let first = chars.popFirst()