Namespace conflicts likely with MCStopProxy stop method

matthewcheok / POP-MCAnimate

Concise syntax for the Pop animation framework.

MIT License

947 stars 105 forks source link

Namespace conflicts likely with MCStopProxy stop method #16

Open pquimby opened 8 years ago

pquimby commented 8 years ago

I recently fixed a bug in my codebase caused by having the stop method injected via a category as a part of the MCANIMATE_SHORTHAND define. We have another class from a third-party source with a method name stop. It would be appreciated, since the MCStopProxy category injects into NSObject that is have a more unique name like stopAnimation to avoid any number of other uses of the method name stop.

matthewcheok commented 8 years ago

That's precisely why MCANIMATE_SHORTHAND exists - it provides convenience at a cost. Your suggestion does have merit though and I'd be happy take a PR :)