search

matthewdeanmartin / openmock

Python Opensearch Mock for test purposes (fork of elasticmock)
https://pypi.python.org/pypi/openmock
MIT License
12 stars 11 forks source link

Add `min_score` param & add `MINIUM_SHOULD_MATCH` implementation #18

Closed TECH7Fox closed 7 months ago

TECH7Fox commented 8 months ago

For our tests we need the min_score param in the count function, and a MINIUM_SHOULD_MATCH implementation. Our tests work as expected with these changes.

TECH7Fox commented 7 months ago

@matthewdeanmartin could you take a look at this? I would be happy to make changes if needed.

matthewdeanmartin commented 7 months ago

Sorry, didn't see this last month. I'll get a release out today. Thanks for the MR!

TECH7Fox commented 7 months ago

No problem, thank you!

TECH7Fox commented 7 months ago

Did you get a chance to release this yet? Did you consider making a action to automatically release it on pypi when you create a new release on Github or make a new tag or something?

matthewdeanmartin commented 7 months ago

2.3.6 is there now. The hold up was a precommit checking if the poetry lock file was up to date.

What I need is ChatGPT to do some of these tasks. A business rule to always publish on successful build is wrong n% of the time & it is wrong n% of the time to only publish on manual trigger.