search

matthewdias / kitsu-updater

Browser extension to automatically update your Kitsu library from streaming sites
https://chrome.google.com/webstore/detail/kitsu-updater/maaganaggnnofcmkongapkhkjlehedfj
MIT License
16 stars 2 forks source link

No UI change after logging in #3

Closed tejassharma96 closed 7 years ago

tejassharma96 commented 7 years ago

When I log in, nothing appears to happen in the extension. However, if I go to cruncyroll and watch something, then the extension updates correctly and lets me scrobble to my kitsu account. The code looks like it's meant to change to show a us our profile picture and username once we're logged in, and it clearly isn't doing that. At first I thought it might be because I was using vivaldi instead of chrome, which can be buggy sometimes so I tried on chrome and it still didn't work.

tejassharma96 commented 7 years ago

Restarting the browser doesn't change anything visually, but I can confirm that I'm still logged in after doing so

wopian commented 7 years ago

If you're logged in it shows your avatar and username in the menu:

tejassharma96 commented 7 years ago

Yeah I figured it was meant to, but it doesn't for me. Just continues to show the username and password input fields as if I wasn't, even though I can scrobble to my account.

matthewdias commented 7 years ago

that's odd. do you think you could inspect the popup and see if there are any errors?

tejassharma96 commented 7 years ago

You need a null check :-) Error in event handler for (unknown): TypeError: Cannot read property 'avatar' of null at sendMessage (chrome-extension://maaganaggnnofcmkongapkhkjlehedfj/js/options.js:88:25) Indeed, after setting an avatar it now shows up.

matthewdias commented 7 years ago

ahh, i was supposed to fix that but forgot 😞 thanks for the reminder.

matthewdias commented 7 years ago

fixed in latest release