search

matthewdias / kitsu-updater

Browser extension to automatically update your Kitsu library from streaming sites
https://chrome.google.com/webstore/detail/kitsu-updater/maaganaggnnofcmkongapkhkjlehedfj
MIT License
16 stars 2 forks source link

Masterani.me updating isn't working #4

Closed tejassharma96 closed 7 years ago

tejassharma96 commented 7 years ago

I was trying to use masterani.me, but the add-on was just showing me the regular home page when watching anime. I went through the source code and updated the strategy for masterani.me in your media-strategies repo. Please could you accept the pull request so I can update from masterani.me. https://github.com/matthewdias/media-strategies/pull/1

matthewdias commented 7 years ago

yeah, sorry i saw it, just didn't get to it today. i'll tweak the code a bit and get it in tomorrow. thanks for the pull requests!

tejassharma96 commented 7 years ago

Cool, just wanted to make sure you had seen it :-)

matthewdias commented 7 years ago

thanks again!

tejassharma96 commented 7 years ago

:)

tejassharma96 commented 7 years ago

So I updated the extension but it appears it is still not working. Does it work on your end?

matthewdias commented 7 years ago

Ah! i forgot to add it to the settings page.

tejassharma96 commented 7 years ago

For 9anime? Cool, but it doesn't work for masterani either on my end.

tejassharma96 commented 7 years ago

Do you think it could be an http vs https situation?

Update: On checking what document.URL returns in the console, it is indeed a http vs https situation. Gonna make a pull request that should hopefully change that.

matthewdias commented 7 years ago

ah, they switched to https. ill update all the urls to handle both http and https. edit: just saw ur comment. nice catch.

tejassharma96 commented 7 years ago

Ah ok was about to make the pull request but it'll probably be faster if you just do it haha 9anime is https too fyi

matthewdias commented 7 years ago

alright i've fixed the issues with masterani and 9anime, update should roll out shortly.

tejassharma96 commented 7 years ago

Confirmed working on both masterani and 9anime