search

matthewearl / faceswap

Python script to put facial features from one face onto another
MIT License
1.4k stars 496 forks source link

Added optional argument for the output file #2

Closed akozlik closed 9 years ago

akozlik commented 9 years ago

Added an optional parameter to control the output file.

akozlik commented 9 years ago

Hi just wanted to follow up with this and see if you're accepting pull requests.

matthewearl commented 9 years ago

Sorry for the delay: I've been away from my computer for the last 10 days or so. I like the idea of having an optional output argument, however I think it'd be better with an explicit flag (-o), and argparse. Simply reading sys.argv[3] seems risky in that the user is liable to accidentally put an input file as the third argument, thereby overwriting it.

akozlik commented 9 years ago

No problem at all, I appreciate the reply. Argparse makes a lot of sense. I haven't done too much python work so I wasn't aware of a best practice. I'll update the codebase and issue another PR if that's OK with you.

matthewearl commented 9 years ago

No problem!