matthewfeickert / HEPML-env

A minimal Python3 environment for HEP machine learning with pipenv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Have Pipfile require Python 3.6 or above #11

Open matthewfeickert opened 6 years ago

matthewfeickert commented 6 years ago

At the moment the Pipfile has

[requires]
python_version = "3.6"

This was generated by pipenv, however, this should be moved to something like

python_version = {">=3.6"}

or however pipenv properly does this.

matthewfeickert commented 6 years ago

Apparently this is not viable at the moment in pipenv (rather unfortunate).

9034725985 commented 6 years ago

at https://github.com/DangerOnTheRanger/maniwani/pull/19 we decided to simplify our pipfile lock by simply saying python 3.

python_version = "3"
matthewfeickert commented 6 years ago

@9034725985 Thanks for the feedback. However, I do want to enforce that people are using Python 3.6 or later, so I'll have to try and figure out a hacky way to do this later.

florent-vial commented 5 years ago

at DangerOnTheRanger/maniwani#19 we decided to simplify our pipfile lock by simply saying python 3.

python_version = "3"

This does not work for us either: pipenv check Checking PEP 508 requirements…

Specifier python_version does not match 3 (3.6).

Failed!